Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 16.0 #886 +/- ##
==========================================
- Coverage 44.28% 44.24% -0.04%
==========================================
Files 317 318 +1
Lines 6294 6313 +19
Branches 1000 1003 +3
==========================================
+ Hits 2787 2793 +6
- Misses 3486 3499 +13
Partials 21 21 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
eantones
force-pushed
the
16.0-fix-rental_base_extension-rental_service_button_multivariant
branch
from
631a5e2 to
0e934ef
Compare
…ant products The "Create Rental Service" button and the "Rentals" section were hidden on product templates with more than one variant, preventing users from creating rental services for existing products with variants (e.g. regulators with sizes, wetsuits with sizes). Now the "Rentals" section is visible for all storable products regardless of variant count. For single-variant products, the original wizard is used. For multi-variant products, a new button creates rental services for all variants at once. Also restrict the "Can be Rented" checkbox and the "Rentals" section to storable products only (type == 'product'), hiding them for consumables and services.
…tion
Add Catalan and Spanish translations for the new strings introduced
by the multi-variant rental service creation:
- "Create Rental Services" button label
- "Created Rental Services" action window name
- "All variants already have a rental service." error message
Reuse the parent module's "Rental of a {}" and "RENT-{}" strings
(via .format()) so we share the existing translation keys with
sale_rental's wizard.
Update rental_base_extension.pot with the new entries.
eantones
force-pushed
the
16.0-fix-rental_base_extension-rental_service_button_multivariant
branch
from
0e934ef to
94b0096
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan